[action] [PR:16169] Correcting client arguments to dynamically_compensate_leakout in PGSharedWatermarkTest#407
Merged
mssonicbld merged 1 commit intoAzure:202503from Jun 16, 2025
Conversation
…GSharedWatermarkTest` In sonic-net/sonic-mgmt#8149 the `multi-asic` and `multi-dut` variants were added to `test_qos_sai.py`. This required updating calls to `dynamically_compensate_leakout` to specify either the `src_client` or dst_client` but a couple calls in `PGSharedWatermarkTest` passed the wrong client. For more details on the failure this causes see sonic-net/sonic-mgmt#16167 Summary: Fixes #16167 ### Type of change - [x] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] Test case(new/improvement) ### Back port request - [ ] 202012 - [ ] 202205 - [ ] 202305 - [ ] 202311 - [x] 202405
Collaborator
Author
|
Original PR: sonic-net/sonic-mgmt#16169 |
Collaborator
Author
|
/azp run |
8 tasks
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In sonic-net/sonic-mgmt#8149 the
multi-asicandmulti-dutvariants were added totest_qos_sai.py.This required updating calls to
dynamically_compensate_leakoutto specify either thesrc_clientor dst_clientbut a couple calls inPGSharedWatermarkTest` passed the wrong client.For more details on the failure this causes see sonic-net/sonic-mgmt#16167
Summary:
Fixes #16167
Type of change
Back port request